#24 Proxied procs aren't getting cleaned up - Johnson

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#24 ✓resolved

Proxied procs aren't getting cleaned up

Reported by John Barnette | 2008-04-02 02:01:01 UTC

The JSClass for JSObjects representing JSFunctions (js_FunctionClass) just uses JS_FinalizeStub, which means we aren't cleaning Ruby procs out of @gcthings or context->rbids. Consider setting the stub for all JSFunctions if we can safely get away with it.

Comments and changes to this ticket

John Barnette 2008-04-02 10:54:39 UTC
- State changed from “new” to “open”
- Title changed from “Proxies procs aren't getting cleaned up” to “Proxied procs aren't getting cleaned up”
John Barnette 2008-04-03 10:14:53 UTC
Yeah, we should just reach in to js_FunctionClass and inject a custom finalize stub. See if it has the magical "this is a Ruby proc" marker property, and, if it does, cleanup as normal.
John Barnette 2008-04-07 15:55:31 UTC
Alternatively, we could start having a lot more JSland proxy classes:
- JSProxyClass, for most Ruby objects, including Hashes
- JSArrayProxyClass, for Ruby arrays
- JSProcProxyClass, for Ruby procs
John Barnette 2008-04-20 22:49:29 UTC
- State changed from “open” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.