Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

Proxied procs aren't getting cleaned up

#24

The JSClass for JSObjects representing JSFunctions (js_FunctionClass) just uses JS_FinalizeStub, which means we aren't cleaning Ruby procs out of @gcthings or context->rbids. Consider setting the stub for all JSFunctions if we can safely get away with it.

Reported by John Barnette · April 2nd, 2008 @ 02:01 AM

State: resolved
Milestone: none
Assigned to: John Barnette John Barnette

Activity

  1. John Barnette
    John Barnette
    • State changed from new to open
    • Title changed from Proxies procs aren't getting cleaned up to Proxied procs aren't getting cleaned up

    April 2nd, 2008 @ 10:54 AM

  2. John Barnette
    John Barnette

    Yeah, we should just reach in to js_FunctionClass and inject a custom finalize stub. See if it has the magical "this is a Ruby proc" marker property, and, if it does, cleanup as normal.

    April 3rd, 2008 @ 10:14 AM

  3. John Barnette
    John Barnette

    Alternatively, we could start having a lot more JSland proxy classes:

    • JSProxyClass, for most Ruby objects, including Hashes
    • JSArrayProxyClass, for Ruby arrays
    • JSProcProxyClass, for Ruby procs

    April 7th, 2008 @ 03:55 PM

  4. John Barnette
    John Barnette
    • State changed from open to resolved

    April 20th, 2008 @ 10:49 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.